• aksdb@lemmy.world
    link
    fedilink
    arrow-up
    1
    ·
    edit-2
    5 days ago

    Can a maintainer really NACK any patch they dislike? I mean I get that Hellwig said he won’t merge it. Fine. What if for example Kroah-Hartman says “whatever, I like it” and merges it nonetheless in his tree?

    • LeFantome@programming.dev
      link
      fedilink
      arrow-up
      4
      ·
      5 days ago

      I doubt Greg is pulling in Rust until it has been through the mainline. That said, Linus can merge anything he wants.

      • aksdb@lemmy.world
        link
        fedilink
        arrow-up
        2
        ·
        5 days ago

        It was an example. I don’t have a fucking clue how all the maintainers are named.

        The main question was: why can a maintainer NACK something not in their responsibility? Isn’t it simply necessary to find one maintainer who is fine with it and pulls it in?

        Or even asked differently: shouldn’t you need to find someone who ACKs it rather than caring about who NACKs it?

        • LeFantome@programming.dev
          link
          fedilink
          arrow-up
          1
          ·
          edit-2
          3 days ago

          Let me just say that hierarchies are for breaking ties.

          The normal process is that Linus prefers we all work through maintainers to cut down on the noise that comes to him. In this case, the maintainer is the reason the noise is coming to Linus. So, it will be up to him to settle it.

    • catloaf@lemm.ee
      link
      fedilink
      English
      arrow-up
      1
      ·
      5 days ago

      Yes, but asking him in this case was basically a courtesy, the code isn’t going into anything he manages. He can reject it, but that’s an opinion, not a decision. It can still be merged if the regular maintainer (or someone senior like Linus himself) approves.