Code monkey think maybe Manager want to write Godamned login page himself

remember kids, scope creep kills things.

it killed my startup 👍

I love this scene. Taught me what “yak shaving” is and helps me explain it to other people.

I just got home from a 12 hour day of work. This has been my entire week.

Help.

The real lesson here is don’t re-invent the wheel. There are plenty of companies that have fully fleshed out auth/login solutions for you already. I never cease to be amazed with how many companies insist on building shit that already exists and come up with an obviously far shittier implementation.

I’m Hedgehog, the poor senior dev who was assigned to review Hal’s code.

Panel 1: ✅ (PR Approved) LGTM but you’re missing the styling from the mock-ups, should be easy to add.

Panel 2: ❌ (Changes requested)

Nit: Hal, your PR failed in CI. You should have used const instead of let. Did you forget to run the linter before pushing?

Also, the useState hook isn’t doing anything. If it doesn’t need to, just leave it as an uncontrolled component. I didn’t look at the surrounding code but this is part of a form, right? If not then it should be receiving the setter/value as props.

Panel 3: ✅ LGTM, ship it.

❌ Actually wait, you still have that do-nothing state code in there. Either get rid of it or do something with it.

Panel 4: ❌ Hal, I don’t like where this is going.

Panel 5: (during stand-up) I reviewed Hal’s PR and just had a couple pieces of feedback. Shouldn’t take long, right, Hal?

Panel 6: ❌ WTF, Hal. <InputField /> is literally just passing through props to input, so you don’t need it.

Also, Hal, I recommend you look into the Styled Components library. It might better fit your needs here. You could rewrite the LoginComponent as a styled input. Of course, if you do that you should refactor the existing places where you’re using style sheets to use styled components and themes instead.

You also still have the do-nothing useState hook for some reason. Seriously, Hal, get rid of it.

This is how I’d write this without bringing in Styled Components, but if you use it make sure to test it first:

import React from ‘react’;
export const LoginForm = (props: React.ComponentPropsWithoutRef<‘input’>) => (
  <input
    {...props}
    className={`border rounded-md p-2 focus:outline-none focus:border-blue-500 ${props.className || ‘‘}`}
  />
);

Should have been “Hal, did you center the div?”

Also, Hal shoulda just used an UI library!