JPDev@programming.dev to Programmer Humor@programming.dev · 1 year agoReview Pleaseprogramming.devimagemessage-square112fedilinkarrow-up1994arrow-down117
arrow-up1977arrow-down1imageReview Pleaseprogramming.devJPDev@programming.dev to Programmer Humor@programming.dev · 1 year agomessage-square112fedilink
minus-squareswordsmanluke@programming.devlinkfedilinkarrow-up14·1 year agoNet removal of 1500 LoC… I’m gonna make you break this up into multiple PRs before reviewing, but honestly, if your refactoring reduced the surface area by 20% I’m a happy man.
minus-squareGraz@feddit.delinkfedilinkarrow-up1·1 year agoit’s just removed unit tests that didn’t work any more…
Net removal of 1500 LoC…
I’m gonna make you break this up into multiple PRs before reviewing, but honestly, if your refactoring reduced the surface area by 20% I’m a happy man.
it’s just removed unit tests that didn’t work any more…
😱