• dan@upvote.au
    link
    fedilink
    arrow-up
    1
    ·
    7 months ago

    You can make a PR against your feature branch and have that reviewed

    But what if you have multiple PRs that depend on each other? Or are you saying only have one PR open at a time? That sounds like it’d be very slow?

    • iknowitwheniseeit@lemmynsfw.com
      link
      fedilink
      arrow-up
      1
      ·
      7 months ago

      I suppose it is possible to have two PR that have changes that depend on each other. In general this just requires refactoring… typically making a third PR removing the circular dependency.

      It sounds like your policy is to keep PR around a long time, maybe? Generally we try to have ours merged within a few days, before bitrot sets in.

      • dan@upvote.au
        link
        fedilink
        arrow-up
        1
        ·
        7 months ago

        Sorry, my comment was unclear. I didn’t mean a circular dependency, just PRs that have a chain of dependencies (e.g. PR 100 that depends on 99, that depends on 98, that depends on 97)

        They’re usually not around for a long time, but there can be relatively large chains if someone is quickly adding new features.